you mean the buffer or the size ?
you mean the buffer or the size ?
Cheers for the heads up! yes there are many examples in our lives of driver developers and to some extent hardware designers not following the specs. What seems like a lifetime of GL woes between ATI, Nvidia and various other vendors has left me jaded and bitter. Ok, mainly bitter.
When the moon hits your eye like a big pizza pie - that's an extinction level impact event.
The documentation says nothing about dwBytes parameter being zero. Under debugging circumstances you can expect SERR_INVALIDCALL when passing zero, but for retail builds I wouldn't rely on it.
Generally speaking, you should always use common sense when working with API. Check special conditions *before* making API calls and do not test API against special circumstances.
Specifically, drivers have no obligations to check whether the parameters you have passed are correct or not. OpenGL is very forgiving in this case, but DirectX and other related APIs are not, so you need to take extra care yourself.
I expect at least DSERR_INVALIDPARAM, otherwise for what this constant is? Common sense says me that this method should have some checks inside And this a normal return value for many of configurations, but not for ASUS Xonar DS one...Under debugging circumstances you can expect SERR_INVALIDCALL
In my experience, SERR_INVALIDCALL (and its equivalent in WinAPI / DX) is more common when parameters are incorrect, even though there are more meaningful error codes.
API and drivers cannot predict all possible invalid values that you can put through this method. Therefore, it is your responsibility to make sure that all parameters are valid and contain meaningful data.
...which is also a normal situation considering that ASUS Xonar DS did not do anything wrong, since they do not need to check for validity of the parameters. The crash is a normal response in this case, which was at your fault for sending invalid data.
Think of it this way: government can make a protection on the trees in case you crash your car into them; however, a more practical approach is to recommend you not to crash your car into the trees and if you crash, it's your fault, not the trees.
I would totally agree with this only if I had passed some invalid pointer or whatever else dangerous, but not a "wrong" size, which can be handled without no problems, this is just a zero, even not a negative value... this is almost the same as if that driver can't allocate memory(for sound buffer) and goes crash instead of returning E_OUTOFMEMORY But this thread is not about why I was so careless, just a warning about very specific problem...which is also a normal situation considering that ASUS Xonar DS did not do anything wrong, since they do not need to check for validity of the parameters. The crash is a normal response in this case, which was at your fault for sending invalid data.
Last edited by Andru; 20-03-2012 at 01:45 PM.
Bookmarks