Silly things we used to do?

**pstudio** · 05-04-2012, 09:09 PM

Not really a mistake but definitely a silly thing I used to do back in my early days:

Code:

var myBool: Boolean;
...
if myBool = true then
  myBool := false
else
  myBool := true;

First I figured out that there was no reason to type

Code:

if myBool = true then

when I could just type

Code:

if myBool then

Later I figured out simply to write

Code:

myBool := not myBool;

I comfort myself having seen many beginners write the same kind of code. It's nice to know I'm not the only one

**FelipeFS** · 05-07-2012, 07:43 PM

Code:

FVar : Booelan;

if FVar = True then
begin
  ...
end;

Actually I like doing that!!! I think it is more readable than:

Code:

if FVar then
begin
  ...
end;

**User137** · 06-07-2012, 05:44 AM

Not that i have ever done this, but i can imagine the above code would be about same as this

Code:

if (a = b) = True then
begin
  ...
end;

Let's hope the compilers know how to optimize the extra comparison out of executable.

**pitfiend** · 08-07-2012, 07:50 PM

Originally Posted by User137

Not that i have ever done this, but i can imagine the above code would be about same as this

Code:

if (a = b) = True then
begin
  ...
end;

Let's hope the compilers know how to optimize the extra comparison out of executable.

As far as I know, Delphi has a shortcut evaluator for booleans. But this is going to push it to the limits

**pstudio** · 08-07-2012, 10:12 PM

Originally Posted by pitfiend

As far as I know, Delphi has a shortcut evaluator for booleans. But this is going to push it to the limits

I can't see why a compiler should have a hard time optimizing the code. It seems to me, it would be simple to add a rule saying something like:

Code:

if our code says
   boolean = True
then replace the code with
   boolean

This should be quite easy when you've made a syntax tree.

**pitfiend** · 09-07-2012, 01:57 AM

Originally Posted by pstudio

I can't see why a compiler should have a hard time optimizing the code. It seems to me, it would be simple to add a rule saying something like:

Code:

if our code says
   boolean = True
then replace the code with
   boolean

This should be quite easy when you've made a syntax tree.

I misspelled my statement, I wanted to mean: this is pushing the limits of stupidity. Didn't want to sound rude or politicaly incorrect.

**pstudio** · 09-07-2012, 03:30 AM

Ah ok, then I misunderstood you

Thread: Silly things we used to do?