Converting ASM to Pascal

[Cybermonkey]

Ok, thanks, but I have no clue what you are talking about. The complete code is not by me but by someone else, I just wanted the program to compile with 64 bit Freepascal ...

[Colin]

if the functions that are called by "CallFunction" are 32-bit libraries functions etc, then you should not have a problem to compile this on 64-bit pascal, but if you re-compile the libs it calls into 64-bit then you will have a-lot of work ahead.

What i would suggest is to rename this function to CallFunctionX86(... and make sure all pointers and variables used are 32-bit standard, e.g. pointer should be 32-bit pointer (i don't use freepascal dunno which you will need to use)

then you can create a new function CallFunctionX64(

This would be similar but using 64-bit variables and registers.

[Cybermonkey]

Ok, but I learned that "mov EAX" etc. isn't available on 64 bit processors, is it?

[Colin]

it is, eax is 32-bit part of RAX, maybe TASM or pascal assembler does not support mov with 32-bit regs (eax, ecx etc) in 64-bit mode (if so that is flawed)

so if mov eax, _EAX does not work try either:

movd eax, _EAX

or

mov rax, dword _EAX

[Cybermonkey]

It is even worse, "push esi" isn't known either. I added the compiler directive {$asmmode intel}. Now the problems are:

Chip.pas(2041,13) Error: Asm: [push reg32] invalid combination of opcode and operands
Chip.pas(2042,13) Error: Asm: [push reg32] invalid combination of opcode and operands
Chip.pas(2066,12) Error: Asm: [pop reg32] invalid combination of opcode and operands
Chip.pas(2067,12) Error: Asm: [pop reg32] invalid combination of opcode and operands

Another problem causes this piece of code (it's obviously Pascal, but i don't know to solve it either):

      args.outVal.n.sbuf:=basicstring(resvalue);
      basicstring(resvalue):=''

Error:

Chip.pas(2076,27) Error: Illegal type conversion: "LongInt" to "AnsiString"
Chip.pas(2077,7) Error: Illegal type conversion: "LongInt" to "AnsiString"

With a 32 bit FPC it compiles ... BTW, the complete source of Chip.pas can be found on: http://xmojmr.ohmygod.cz/software/Chip/Chip.pas.htm

[Colin]

I guess the assembler does some checking for stack alignment to prevent problems with other 64-bit libs, this is an issue with the assembler unless it has an override option, maybe try

[32BIT]
push edi
push .. etc

as for the other code, does basicstring return a pchar/pointer? if so try

basicstring(resvalue)^ := ''

better still:

var
  p: PAnsiChar;

p := basicstring(resvalue);
args.outVal.n.sbuf := p;
p^ := ''

[phibermon]

I'm glad you're here, I got as far as "ahh, it's pushing params onto the stack for the routine that's called", I'd worked out we'd need to see more of the code to understand the context, the function that's called etc meanwhile you've already sorted it